feat!: add interactive Polygons, rework Polyline hitTest result, and deprecate/disable auto application of TransulcentPointer#1822
Merged
JaffaKetchup merged 5 commits intomasterfrom Feb 14, 2024
Conversation
JaffaKetchup
requested review from
TesteurManiak,
ibrierley,
josxha and
mootw
This comment was marked as outdated.
This comment was marked as outdated.
JaffaKetchup
force-pushed
the
interactive-polygons
branch
from
908421e to
f9d37df
Compare
Improved example application to showcase Polygon interactivity
Minor performance improvements
This comment was marked as outdated.
This comment was marked as outdated.
Removed auto application of `TransulcentPointer`, deprecated respective option, and fixed bug Minor performance improvement Minor documentation improvement
JaffaKetchup
changed the title
PolygonsPolygons, rework Polyline hitTest result, and deprecate/disable auto application of TransulcentPointer
josxha
reviewed
Feb 14, 2024
Contributor
josxha
left a comment
josxha
left a comment
There was a problem hiding this comment.
Haven't tested yet. Changes look straight forward, only found one thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added interactive
PolygonsResolves #385. Requires #1800 to be merged first.
This uses a similar format as to
Polylineinteractivity.Reworked
PolylinePainter.hitTestoutputsHelps to fix #1740.
hitNotifierhitValueshitTestinternal output no longer depends on state ofhitNotifier, to improve definitity without below...Deprecated
MapOptions.applyPointerTranslucencyToLayers& changed default tofalse, and removed usageTransulcentPointer.translucentpropertyFixes #1740.
MapOptions.applyPointerTranslucencyToLayerscausesPositionedwrappers to fail #1740 was caused because disabling it did not unwrap children, it just used thetranslucentpropertyTranslucentPointeritself has been retained as it is a useful resource to further customize hit testing behaviour, andCircleLayerandOverlayImageLayerstill have no hit testing provision