expose centerzoom, public getBoundsCenterZoom and Anchor.forPos#306
Merged
johnpryan merged 2 commits intofleaflet:masterfrom Jun 7, 2019
lpongetti:master
Merged
expose centerzoom, public getBoundsCenterZoom and Anchor.forPos#306johnpryan merged 2 commits intofleaflet:masterfrom lpongetti:master
johnpryan merged 2 commits intofleaflet:masterfrom
lpongetti:master
Conversation
johnpryan
requested changes
Jun 6, 2019
| throw Exception('Bounds are not valid.'); | ||
| } | ||
| var target = _getBoundsCenterZoom(bounds, options); | ||
| var target = getBoundsCenterZoom(bounds, options); |
Collaborator
There was a problem hiding this comment.
I think a better way would be to expose this method on MapControllerImpl and MapController instead. Their purpose is to expose the methods on MapState
Contributor
Author
There was a problem hiding this comment.
Inside a plugin theres mapstate and not mapcontroller. So i need getBoundsCenterZoom public from mapstate.
Collaborator
There was a problem hiding this comment.
I see, thanks for the clarification.
Merged
johnpryan
approved these changes
Jun 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
i'm creating a marker cluster plugin with all feature like animation and spiderfy, and this two edits can help me for don't rewrite you code.