remove quiver dep#32
Merged
johnpryan merged 4 commits intofleaflet:masterfrom Jun 7, 2018
avioli:master
Merged
Conversation
johnpryan
reviewed
May 9, 2018
| /// object. | ||
| class _JenkinsSmiHash { | ||
| /// Accumulates the hash code [value] into the running hash [hash]. | ||
| static int combine(int hash, int value) { |
Collaborator
There was a problem hiding this comment.
This makes me think that this will only work with integers, not doubles. Have you tested with doubles in strong mode?
Contributor
Author
There was a problem hiding this comment.
I've removed the JenkinsSmiHash altogether, since dart:ui exposes hashValues()
It was added back from upstream version update
johnpryan
approved these changes
Jun 7, 2018
juliano-souza000
pushed a commit
to juliano-souza000/flutter_map
that referenced
this pull request
Mar 26, 2023
…eb + mobile project (fleaflet#32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed quiver dependency, since the only use is for the
hash3method.Copy/pasted the
JenkinsSmiHashfrom flutter'sfront_endlib and added attribution where needed.BTW: I'm wondering if this hash method is tested/proven useful for doubles, given it is hashing coordinates (which are usually doubles, not integers).
dart:mathuses it internally, but doesn't expose thehashX,combinenorfinishmethods, so that is of no use. It's attribution is also missing, thus using thefront_endcodebase.