Merged
Conversation
Contributor
|
@maRci002 @HugoHeneault I compared rendering quality of this Flutter lib to the native The map looked better and more crisp on I traced down the complete widget tree to find the issue (image resize algorithm, ...). |
Allenisme
approved these changes
Apr 28, 2020
…' into support_retina_mode # Conflicts: # lib/src/layer/tile_layer.dart
Contributor
Author
|
#584 updated so I merged that into this to avoid conflicts whenever they got approved. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I made some changes to support simulating retina mode (note: If geoserver supports retina
@2tiles then it it advised to use them instead of simulating).It won't detect if device supports retina because I don't want force user to use
Material appbecause ofMediaQuery.of(context).However it is documented how to use it:
Moreover if retina is enabled then
MapOptions'smaxZoomshould bemaxZoom - 1, currentlyMapStatedoesn't detect anymaxZoombased on Layers like Leaflet (If not specified and at least oneGridLayerorTileLayeris in the map, the highest of theirmaxZoomoptions will be used instead.).Note: this PR needs #584 so merge this only when it is accepted.
closes #212