Skip to content

Fix gray tiles when tile image is already avaible #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnpryan merged 3 commits into from
Aug 4, 2020
Merged

Fix gray tiles when tile image is already avaible #715

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fb7fdd
Make sure tile loads asynchronously
maRci002 Aug 4, 2020
e56f3d2
Run asynchronously only when necessary
maRci002 Aug 4, 2020
7413bba
Remove async callbacks and call `loadTileImage` when tile is in `_tiles`
maRci002 Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/src/layer/tile_layer.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,7 +936,7 @@ class _TileLayerState extends State<TileLayer> with TickerProviderStateMixin {

void _addTile(Coords<double> coords) {
var tileCoordsToKey = _tileCoordsToKey(coords);
_tiles[tileCoordsToKey] = Tile(
var tile = _tiles[tileCoordsToKey] = Tile(
coords: coords,
coordsKey: tileCoordsToKey,
tilePos: _getTilePos(coords),
Expand All @@ -946,6 +946,8 @@ class _TileLayerState extends State<TileLayer> with TickerProviderStateMixin {
options.tileProvider.getImage(_wrapCoords(coords), options),
tileReady: _tileReady,
);

tile.loadTileImage();
Copy link
Copy Markdown
Collaborator

@johnpryan johnpryan Aug 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick) This code could use the cascade operator to simplify:

_tiles[tileCoordsToKey] = Tile(
  // ...
)..loadTileImage();

Copy link
Copy Markdown
Contributor Author

@maRci002 maRci002 Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it but didn't work. I'll give it another try maybe hotreload bugged.

Copy link
Copy Markdown
Contributor Author

@maRci002 maRci002 Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I retried it didn't work. I think this happens under hood when cascade operator is used.

  1. Tile object created
  2. loadTileImage method called on Tile
  3. Tile added to _tiles[tileCoordsToKey]

With temp variable this happens:

  1. Tile object created
  2. Tile added to _tiles[tileCoordsToKey]
  3. loadTileImage method called on Tile

So even if loadTileImage's callback is synchronous we are sure it is already in _tiles map.

}

void _tileReady(Coords<double> coords, dynamic error, Tile tile) {
Expand Down Expand Up @@ -1078,9 +1080,7 @@ class Tile implements Comparable<Tile> {
this.active = false,
this.retain = false,
this.loadError = false,
}) {
loadTileImage();
}
});

void loadTileImage() {
try {
Expand Down