Skip to content

Feature #727 | Replace latlong with maps_toolkit#750

Closed
yakanet wants to merge 2 commits intofleaflet:masterfrom
yakanet:feature/replace_latlong_with_maps_toolkit
Closed

Feature #727 | Replace latlong with maps_toolkit#750
yakanet wants to merge 2 commits intofleaflet:masterfrom
yakanet:feature/replace_latlong_with_maps_toolkit

Conversation

@yakanet
Copy link
Copy Markdown

@yakanet yakanet commented Sep 21, 2020

As mentioned in #727 , replace latlong dependency with maps_toolkit.

The change is minimal, but it might create some breaking changes with other libs based on flutter_map, as the package name for the LatLong class is not the same, and the class LatLong is now immutable.

In most of the cases just replace the package name with the following:

- import 'package:latlong/latlong.dart';
+ import 'package:maps_toolkit/maps_toolkit.dart';

clean: remove debug file

chore: fix format issues
@yakanet yakanet force-pushed the feature/replace_latlong_with_maps_toolkit branch from b9c3a0e to 9e41304 Compare September 28, 2020 09:49
@kengu
Copy link
Copy Markdown
Contributor

kengu commented Mar 16, 2021

@yakanet Could you fix the conflicts before we look into your proposed switch to maps_toolkit?

@maRci002
Copy link
Copy Markdown
Contributor

maRci002 commented Mar 16, 2021

This package seems good, just resolve conflicts. I kinda like this package LatLng's hashCode override version.
However there isn't nullsafe version of it yet.

@danilocubos
Copy link
Copy Markdown

#854 Fixes this problem.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2021

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the Stale label May 2, 2021
@1075dn
Copy link
Copy Markdown

1075dn commented May 14, 2021

I would prefer switching to maps_toolkit as well.

@github-actions github-actions Bot removed the Stale label May 15, 2021
@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions Bot added the Stale label Jun 17, 2021
@ibrierley
Copy link
Copy Markdown
Contributor

Not sure if this is still necessary now, would like to hear if people think it is and why, as there were conflicts and maps_toolkit can be used standalone if I'm understanding it correctly ?

@JaffaKetchup
Copy link
Copy Markdown
Member

Would agree. Not sure if this is necessary now the new version of 'latlong2' is being used?

@github-actions github-actions Bot removed the Stale label Jan 31, 2022
@JaffaKetchup
Copy link
Copy Markdown
Member

I'm going to close this as 'latlong2' is now being used, which already has some of the same extra features as 'maps_toolkit'. Besides, if those extra functions are needed, you can just require that library separately?

Thanks for your contribution!

@JaffaKetchup
Copy link
Copy Markdown
Member

Ok, for now, I'm going to close this PR. I don't think it's necessary anymore, and might cause more problems than create benefits.
Thank you for your contribution, and feel free to submit more in the future should you feel the need to. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants