Feature #727 | Replace latlong with maps_toolkit#750
Feature #727 | Replace latlong with maps_toolkit#750yakanet wants to merge 2 commits intofleaflet:masterfrom
Conversation
clean: remove debug file chore: fix format issues
b9c3a0e to
9e41304
Compare
|
@yakanet Could you fix the conflicts before we look into your proposed switch to maps_toolkit? |
|
This package seems good, just resolve conflicts. I kinda like this package LatLng's |
|
#854 Fixes this problem. |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
I would prefer switching to |
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
Not sure if this is still necessary now, would like to hear if people think it is and why, as there were conflicts and maps_toolkit can be used standalone if I'm understanding it correctly ? |
|
Would agree. Not sure if this is necessary now the new version of 'latlong2' is being used? |
|
I'm going to close this as 'latlong2' is now being used, which already has some of the same extra features as 'maps_toolkit'. Besides, if those extra functions are needed, you can just require that library separately? Thanks for your contribution! |
|
Ok, for now, I'm going to close this PR. I don't think it's necessary anymore, and might cause more problems than create benefits. |
As mentioned in #727 , replace latlong dependency with maps_toolkit.
The change is minimal, but it might create some breaking changes with other libs based on flutter_map, as the package name for the LatLong class is not the same, and the class LatLong is now immutable.
In most of the cases just replace the package name with the following: