Add Caching Implementations to README#841
Merged
johnpryan merged 1 commit intofleaflet:masterfrom Mar 16, 2021
mootw:master
Merged
Add Caching Implementations to README#841johnpryan merged 1 commit intofleaflet:masterfrom mootw:master
johnpryan merged 1 commit intofleaflet:masterfrom
mootw:master
Conversation
Collaborator
|
This looks good, I think many of these caching solutions could be implemented using a separate package too. |
johnpryan
approved these changes
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added recommended caching implementations for developers to use in readme (since flutter_map does not natively provide caching to reduce dependency requirements and since caching is such a use-case specific thing); however caching can be easily implemented with flutter_map using any Flutter ImageProvider that caches. This gives the app developer more control and reduces flutter_map maintainer load. Adding this to the readme will also lower the amount of Issues and PRs that add caching in many different ways when it should be handled by the developer.
Issues that this should close:
Fixes #832
Fixes #649
Fixes #576 (This issue will not be relevant to this repo and might still exist depending on ImageProvider)
Fixes #752
Fixes #748 (Issue will not be relevant to this repo and still might exist depending on ImageProvider)
Fixes #614 (I think they just did not set up their URL correctly; but this should be closed)
Fixes #402 (Not relevant anymore)
Issues that this could close:
#631 (The issue should be modified or closed)
Here are PRs: that should close:
Fixes #564 (PR adds sqlite dependency and attempts to add caching TileProvider. This should be done as a plugin or developers should use an existing caching image provider)