FOGL-7274: Asset Tracker not able to cope with assets that include sp…#911
FOGL-7274: Asset Tracker not able to cope with assets that include sp…#911Innovative-ashwin wants to merge 7 commits intodevelopfrom
Conversation
…ecial characters Signed-off-by: Innovative-ashwin <sinha.ashwini111@gmail.com>
MarkRiddoch
left a comment
MarkRiddoch
left a comment
There was a problem hiding this comment.
Looks good - I assumed it would be simply a case of missing escape calls somewhere between the service and the database insert.
|
@Innovative-ashwin with above changes ingestion is good, but error in Browse assets readings Following are good though, Stats history dashboard
/cc @MarkRiddoch |
Signed-off-by: Innovative-ashwin <sinha.ashwini111@gmail.com>
Merge branch 'FOGL-7274_new' of https://github.com/fledge-iot/fledge into FOGL-7274_new
|
|
||
| sql_cmd_base += ", id, reading, user_ts, ts "; | ||
| StringReplaceAll (sql_cmd_base, "asset_code", " \"_assetcode_\" .assetcode. "); | ||
| StringReplaceAll (sql_cmd_base, "asset_code", " '_assetcode_' .assetcode. "); |
There was a problem hiding this comment.
This is causing issues now with ''.
There was a problem hiding this comment.
Please test for following:
sin"1
sin"1"
sin'1
sin'1'
sin "#1'
sin :."',."''""`/1
There was a problem hiding this comment.
failed for sin"1, sin"1", sin'1
|
@Innovative-ashwin Note that with commit 3e627b7 SQLIteLB is all good. |
Signed-off-by: Innovative-ashwin <sinha.ashwini111@gmail.com>
Signed-off-by: Innovative-ashwin <sinha.ashwini111@gmail.com>
Signed-off-by: Innovative-ashwin <sinha.ashwini111@gmail.com>
|
@Innovative-ashwin with the newest commit 9edfd59 sin"1 appears as 'sin"1' in assets and readings page; hence no graph rendered. Dashboard/Stats history and South page is good. (Same problem with used sin"1"2) sin'1 sin1'2" does not work; Asset and reading page breaks with storage plugin errors. This is for SQLite plugin. |
@Innovative-ashwin revert to this commit and take care of the reported issues please! |
|
closed by #970 |
|
Can we close this out? |
4 participants
…ecial characters
Signed-off-by: Innovative-ashwin sinha.ashwini111@gmail.com