Skip to content

Allow string concat in LIKE op in query editor#32254

Merged
sgress454 merged 2 commits intomainfrom
sgress454/30854-allow-concat-in-like
Aug 26, 2025
Merged

Allow string concat in LIKE op in query editor#32254
sgress454 merged 2 commits intomainfrom
sgress454/30854-allow-concat-in-like

Conversation

@sgress454
Copy link
Copy Markdown
Contributor

@sgress454 sgress454 commented Aug 25, 2025

for #30854

Details

This PR updates our SQL query parser to allow string concatenation inside of LIKE expressions, e.g.

SELECT * FROM file WHERE path LIKE 'C:' || CHAR(92) || 'Users' || CHAR(92) || 'example.txt';

See https://github.com/sgress454/node-sql-parser/pull/1/files for the code changes in the parser, which are packaged into the changes in this PR using the instructions here.

PR to upstream package:
taozhi8833998/node-sql-parser#2552

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • Added/updated automated tests
    (in upstream repo)

  • QA'd all new/changed functionality manually

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.04%. Comparing base (87880ee) to head (2ae73ac).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32254      +/-   ##
==========================================
- Coverage   64.04%   64.04%   -0.01%     
==========================================
  Files        1988     1988              
  Lines      194440   194442       +2     
  Branches     6514     6513       -1     
==========================================
+ Hits       124521   124522       +1     
- Misses      60221    60222       +1     
  Partials     9698     9698              
Flag Coverage Δ
frontend 52.17% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sgress454 sgress454 merged commit 0a4d03f into main Aug 26, 2025
15 checks passed
@sgress454 sgress454 deleted the sgress454/30854-allow-concat-in-like branch August 26, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants