Allow string concat in LIKE op in query editor#32254
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32254 +/- ##
==========================================
- Coverage 64.04% 64.04% -0.01%
==========================================
Files 1988 1988
Lines 194440 194442 +2
Branches 6514 6513 -1
==========================================
+ Hits 124521 124522 +1
- Misses 60221 60222 +1
Partials 9698 9698
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobshandling
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #30854
Details
This PR updates our SQL query parser to allow string concatenation inside of LIKE expressions, e.g.
See https://github.com/sgress454/node-sql-parser/pull/1/files for the code changes in the parser, which are packaged into the changes in this PR using the instructions here.
PR to upstream package:
taozhi8833998/node-sql-parser#2552
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
Testing
Added/updated automated tests
(in upstream repo)
QA'd all new/changed functionality manually