Skip to content

Fixed bad software ingestion debug message and added filter for invalid software with missing names.#33682

Merged
getvictor merged 2 commits intomainfrom
victor/33681-software-ingestion-dbg-msg
Oct 1, 2025
Merged

Fixed bad software ingestion debug message and added filter for invalid software with missing names.#33682
getvictor merged 2 commits intomainfrom
victor/33681-software-ingestion-dbg-msg

Conversation

@getvictor
Copy link
Copy Markdown
Member

Related issue: Resolves #33681

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • QA'd all new/changed functionality manually

@getvictor getvictor marked this pull request as ready for review October 1, 2025 01:45
@getvictor getvictor requested a review from a team as a code owner October 1, 2025 01:45
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.01%. Comparing base (a5978d1) to head (74d2229).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/software.go 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #33682   +/-   ##
=======================================
  Coverage   64.00%   64.01%           
=======================================
  Files        2067     2067           
  Lines      207195   207209   +14     
  Branches     6817     6817           
=======================================
+ Hits       132625   132635   +10     
- Misses      64140    64143    +3     
- Partials    10430    10431    +1     
Flag Coverage Δ
backend 65.11% <94.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'll report the issue to osquery (the same two entries are pretty consistent and are most likely system apps that shouldn't be returned empty like that):
Screenshot 2025-10-01 at 12 57 07 PM

@getvictor getvictor merged commit ecb8ee1 into main Oct 1, 2025
39 checks passed
@getvictor getvictor deleted the victor/33681-software-ingestion-dbg-msg branch October 1, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad software ingestion debug messages

2 participants