Set ResolvedInVersion for osv vuln scanning#43087
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
Pull request overview
This PR fixes OSV-based Ubuntu vulnerability matching so that detected SoftwareVulnerability records include the ResolvedInVersion (derived from OSV’s fixed version), aligning OSV scan results with existing vulnerability data expectations introduced in #42063.
Changes:
- Populate
fleet.SoftwareVulnerability.ResolvedInVersionfromOSVVulnerability.Fixedwhen present. - Update OSV analyzer unit test expectations to include
ResolvedInVersion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server/vulnerabilities/osv/analyzer.go | Sets ResolvedInVersion for matched OSV vulnerabilities using the OSV fixed field. |
| server/vulnerabilities/osv/analyzer_test.go | Updates expected vulnerabilities to assert ResolvedInVersion is set for range-based matches. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43087 +/- ##
==========================================
- Coverage 66.86% 66.84% -0.02%
==========================================
Files 2578 2578
Lines 206869 206874 +5
Branches 9246 9246
==========================================
- Hits 138328 138294 -34
- Misses 55979 56007 +28
- Partials 12562 12573 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bug fix for #42063 **Related issue:** Resolves #40057 # Checklist for submitter ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually For unreleased bug fixes in a release candidate, one of: - [ ] Confirmed that the fix is not expected to adversely impact load test results --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>


Bug fix for
#42063
Related issue: Resolves #40057
Checklist for submitter
Testing
For unreleased bug fixes in a release candidate, one of: