Skip to content

Handle potential None in rowcounts #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiConnell merged 2 commits into from
Jun 27, 2025
Merged

Handle potential None in rowcounts #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c6b491
handle potential none in model_rowcount
MiConnell Jun 27, 2025
41aff40
handle potential none in source_rowcount
MiConnell Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions macros/upload_models.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
{%- endset -%}
{% endif %}
{%- set results = run_query(rowcount_query) -%}
{%- set model_rowcount = results.columns[0].values()[0] -%}
{%- set raw_value = results.columns[0].values() | first -%}
{%- set model_rowcount = 0 if raw_value is none else raw_value -%}
{% else %}
{%- set model_rowcount = 0 -%}
{% endif %}
Expand All @@ -70,7 +71,7 @@
'{{ tojson(model.tags) }}', {# tags #}
'{{ tojson(model.config.meta) }}', {# meta #}
'{{ null if model.description is not defined else adapter.dispatch('escape_singlequote', 'dbt_observability')(model.description) }}', {# description #}
{{ 0 if model_rowcount is not defined else model_rowcount }} {# total rowcount #}
{{ model_rowcount }}
)
{%- if not loop.last %},{%- endif %}
{%- endfor %}
Expand All @@ -93,7 +94,8 @@
select count(*) as model_rowcount from {{ model.schema }}.{{ model.name }}
{%- endset -%}
{%- set results = run_query(rowcount_query) -%}
{%- set model_rowcount = results.columns[0].values()[0] -%}
{%- set raw_value = results.columns[0].values() | first -%}
{%- set model_rowcount = 0 if raw_value is none else raw_value -%}
{% else %}
{%- set model_rowcount = 0 -%}
{% endif %}
Expand All @@ -113,7 +115,7 @@
{{ tojson(model.tags) }}, {# tags #}
parse_json('{{ tojson(model.config.meta) }}'), {# meta #}
'{{ null if model.description is not defined else adapter.dispatch('escape_singlequote', 'dbt_observability')(model.description) }}', {# description #}
{{ 0 if model_rowcount is not defined else model_rowcount }} {# total rowcount #}
{{ model_rowcount }} {# total rowcount #}
)
{%- if not loop.last %},{%- endif %}
{%- endfor %}
Expand Down
8 changes: 5 additions & 3 deletions macros/upload_sources.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@
{%- endset -%}
{% endif %}
{%- set results = run_query(rowcount_query) -%}
{%- set source_rowcount = results.columns[0].values()[0] -%}
{%- set raw_value = results.columns[0].values() | first -%}
{%- set source_rowcount = 0 if raw_value is none else raw_value -%}

{% else %}

Expand Down Expand Up @@ -101,7 +102,8 @@
and lower(table_schema) = lower('{{ source.schema }}')
{%- endset -%}
{%- set results = run_query(rowcount_query) -%}
{%- set source_rowcount = results.columns[0].values()[0] -%}
{%- set raw_value = results.columns[0].values() | first -%}
{%- set source_rowcount = 0 if raw_value is none else raw_value -%}
{% else %}
{%- set source_rowcount = 0 -%}
{% endif %}
Expand All @@ -117,7 +119,7 @@
'{{ source.identifier }}', {# identifier #}
'{{ adapter.dispatch('escape_singlequote', 'dbt_observability')(source.loaded_at_field) }}', {# loaded_at_field #}
parse_json('{{ tojson(source.freshness) }}'), {# freshness #}
{{ 0 if source_rowcount is not defined else source_rowcount }} {# source_rowcount #}
{{ source_rowcount }} {# source_rowcount #}
)
{%- if not loop.last %},{%- endif %}
{%- endfor %}
Expand Down