Skip to content

Reshape OP #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reyna-abhyankar merged 20 commits into from
Nov 1, 2023
Merged

Reshape OP #1100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5ee6acd
start to do the reshape operator
lambda7xx Sep 6, 2023
0eaee69
add init_task,forward_task, forward_task for reshape
lambda7xx Sep 6, 2023
15ed89c
reshape version0.1 done
lambda7xx Sep 6, 2023
984d616
update the reshape and leave the init_task and measure_operator_task
lambda7xx Sep 24, 2023
8b0a027
refine the reshape pr
lambda7xx Sep 24, 2023
3047c75
remove the replicate
lambda7xx Sep 24, 2023
ea161cd
fix error in reshape
lambda7xx Sep 24, 2023
63cc83d
fix the type error
lambda7xx Sep 26, 2023
5916607
add init_kernel for reshape
lambda7xx Sep 27, 2023
171f05f
modify the reshpae by fixing the typo error
lambda7xx Oct 3, 2023
9cafc2d
Merge branch 'repo-refactor' into repo-refactor-lambda-reshape-OP
lockshaw Oct 6, 2023
143d496
refine the reshape
lambda7xx Oct 10, 2023
bdf4d5e
Merge branch 'repo-refactor-lambda-reshape-OP' of https://github.com/…
lambda7xx Oct 10, 2023
2f798d5
reshape
lambda7xx Oct 17, 2023
803f0c0
format the code
lambda7xx Oct 17, 2023
d9db777
fix the error
lambda7xx Oct 18, 2023
2e3c715
format the code
lambda7xx Oct 19, 2023
33ed163
format the code
lambda7xx Oct 19, 2023
bb4b757
Merge branch 'repo-refactor' into repo-refactor-lambda-reshape-OP
reyna-abhyankar Oct 19, 2023
3bd9b3d
Merge branch 'repo-refactor' into repo-refactor-lambda-reshape-OP
reyna-abhyankar Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions lib/kernels/include/kernels/reshape_kernels.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,28 @@

#include "kernels/accessor.h"
#include "kernels/device.h"
#include "utils/required_core.h"

namespace FlexFlow {

class ReshapePerDeviceState : public PerDeviceOpState {
public:
ReshapePerDeviceState(FFHandler handler);
DataType data_type;
struct ReshapePerDeviceState {
req<DataType> data_type;
};

FF_VISITABLE_STRUCT(ReshapePerDeviceState, data_type);

namespace Kernels {
namespace Reshape {

ReshapePerDeviceState init_kernel(DataType data_type);

void forward_kernel(ffStream_t stream,
ReshapePerDeviceState const *m,
ReshapePerDeviceState const &per_device_state,
GenericTensorAccessorR const &input,
GenericTensorAccessorW const &output);

void backward_kernel(ffStream_t stream,
ReshapePerDeviceState const *m,
ReshapePerDeviceState const &per_device_state,
GenericTensorAccessorW const &input,
GenericTensorAccessorR const &output);

Expand Down
14 changes: 7 additions & 7 deletions lib/kernels/src/cuda/reshape_kernels.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,9 @@

namespace FlexFlow {

ReshapePerDeviceState::ReshapePerDeviceState(FFHandler handler)
: PerDeviceOpState(handler) {}
ReshapePerDeviceState init_kernel(DataType data_type) {
return ReshapePerDeviceState{data_type};
}

namespace Kernels {
namespace Reshape {
Expand All @@ -41,7 +42,6 @@ struct ForwardKernel {
template <DataType T>
struct BackwardKernel {
void operator()(cudaStream_t stream,
ReshapePerDeviceState const *m,
GenericTensorAccessorW const &input,
GenericTensorAccessorR const &output) {
float alpha = 1.0f;
Expand All @@ -54,17 +54,17 @@ struct BackwardKernel {
}

void forward_kernel(cudaStream_t stream,
ReshapePerDeviceState const *m,
ReshapePerDeviceState const &m,
GenericTensorAccessorR const &input,
GenericTensorAccessorW const &output) {
DataTypeDispatch1<ForwardKernel>{}(m->data_type, stream, m, input, output);
DataTypeDispatch1<ForwardKernel>{}(m.data_type, stream, input, output);
}

void backward_kernel(cudaStream_t stream,
ReshapePerDeviceState const *m,
ReshapePerDeviceState const &m,
GenericTensorAccessorW const &input,
GenericTensorAccessorR const &output) {
DataTypeDispatch1<BackwardKernel>{}(m->data_type, stream, m, input, output);
DataTypeDispatch1<BackwardKernel>{}(m.data_type, stream, input, output);
}

} // namespace Reshape
Expand Down
Loading