Change OpCostMetrics.memory to be a nonnegative_int#1586
Merged
lockshaw merged 3 commits intoflexflow:masterfrom Jan 21, 2025
Merged
Change OpCostMetrics.memory to be a nonnegative_int#1586lockshaw merged 3 commits intoflexflow:masterfrom
lockshaw merged 3 commits intoflexflow:masterfrom
Conversation
lockshaw
approved these changes
Jan 21, 2025
Collaborator
lockshaw
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @wmdi)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1586 +/- ##
=======================================
Coverage 60.47% 60.47%
=======================================
Files 606 606
Lines 14723 14725 +2
=======================================
+ Hits 8903 8905 +2
Misses 5820 5820
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Related Issues:
Linked Issues:
Issues closed by this PR:
OpCostMetrics.memoryto be anonnegative_int#1584This change is