Fixed implicit closure in sorting comparator

[stelleg]

Description of changes:
Existing code requires implicit closure over f, which appears to be invalid C++ and fails with g++.

Related Issues:

Linked Issues:

• Issue #

Issues closed by this PR:

• Closes #

Before merging:

• Did you update the flexflow-third-party repo, if modifying any of the Cmake files, the build configs, or the submodules?

[lockshaw]

So this was the fix I had--it seems cleaner, so I'd probably lean toward this unless you have an objection:

 template <typename T, typename F>
 void inplace_sorted_by(std::vector<T> &v, F const &f) {
-  struct {
-    bool operator()(T const &lhs, T const &rhs) { return f(lhs, rhs); }
-  } custom_comparator;
+  auto custom_comparator = [&](T const &lhs, T const &rhs) -> bool {
+    return f(lhs, rhs);
+  };
   
   std::sort(v.begin(), v.end(), custom_comparator);

It's not much code though, so I don't have particularly strong opinions.

[stelleg]

Yep, I prefer yours as well.

[lockshaw]

Great, can you update this PR to have that change and then I'll approve?

[lockshaw]

see above

[lockshaw]

Nevermind, fixed in #850