Add (de)serialization support for data structures in lib/pcg.#988
Closed
tarunprabhu wants to merge 16 commits intoflexflow:repo-refactorfrom
Closed
Add (de)serialization support for data structures in lib/pcg.#988tarunprabhu wants to merge 16 commits intoflexflow:repo-refactorfrom
tarunprabhu wants to merge 16 commits intoflexflow:repo-refactorfrom
Conversation
- Have types use the visitable interface.
- Add stubs for functions/methods that have a declaration but not definition.
These should fail with a "not implemented" message.
- Some code clean up. Remove unnecessary constructors. Delete code that has
been commented out. Remove files that don't contain any non-header files
that do not contain any executable code.
tarunprabhu
force-pushed
the
repo-refactor
branch
from
b13016f to
9e2e1e6
Compare
…there are still missing functions. The lowering to v1 for the CompGraphOperatorAttrs is missing a lot.
…ors. Add stubs with NOT_IMPLEMENTED calls for functions and methods whose definitions are missing.
…tures. Some other to_v1 methods have been provided but will error at runtime due to hitting a NOT_IMPLEMENTED macro. Disable some fields and types because of a bug where std::vector is reported as being not serializable to json. The sole test case builds, but fails because of hitting a a NOT_IMPLEMENTED assertion.
…sabled attrs since the std::vector bug has been fixed. Make the Tensor and ParallelTensor more consistent. The test builds, but doesn't actually test anything.
…m_v1 still remain for the graph as a whole. Add a test for json in lib/utils. Fix some of the parallel tensor classes in op-attrs to be a bit more consistent with the serial tensor, but that may need some changing as well.
…or some incomplete code. There is currently a bug in deserializing FlexFlow::req<T> that prevents the code from building.
…sts. Add an explicit call to join_strings in the FlexFlow namespace in the fmt.
tarunprabhu
changed the title
Author
|
Code for serialization, deserialization to/from v1 and json have been implemented for most (but not all) objects. Tests have been added for most of these as well. Deserialization tests are currently missing due to a bug in |
lockshaw
modified the milestones:
Repo-Refactor: Compiler Completed,
Repo Refactor: Local Execution,
Repo Refactor: C++ UI
Collaborator
|
Superseded by #1394. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BROKEN: This will probably not build. I am adding this PR so you have at least something to look at sooner rather than later.
Have types use the visitable interface.
Add stubs for functions/methods that have a declaration but not definition. These should fail with a "not implemented" message.
Some code clean up. Remove unnecessary constructors. Delete code that has been commented out. Remove files that don't contain any non-header files that do not contain any executable code.
Description of changes:
Related Issues:
Linked Issues:
Issues closed by this PR:
Before merging:
This change is