Avoid unnecessary clearTimeouts in debounce() #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debounce() used to return a function that when first invoked always called `clearTimeout` before `setTimeout`, even if there was no timeout to clear. This change adds a guard to prevent such unnecessary `clearTimeout` calls. The performance implications are likely minimal, but the boolean check should perform better in general than what amounts to a noop function call when `timeout` is `null`. As well, devtools timelines will no longer display a not-useful "Remove Timer" scripting blip for unnecessary `clearTimeout`s.
angus-c
added a commit
that referenced
this pull request
Aug 26, 2014
Avoid unnecessary clearTimeouts in debounce()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
debounce() used to return a function that when first invoked always called
clearTimeoutbeforesetTimeout, even if there was no timeout to clear.This change adds a guard to prevent such unnecessary
clearTimeoutcalls.The performance implications are likely minimal, but the boolean check should
perform better in general than what amounts to a noop function call when
timeoutisnull. As well, devtools timelines will no longer display anot-useful "Remove Timer" scripting blip for unnecessary
clearTimeouts.