Update Advice API doc for event and data params, multiple advice #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashaantt
force-pushed
the
advice_doc_update
branch
from
9656b33 to
295da2a
Compare
Contributor
Author
|
Uh, I looked around and saw you're trying to deprecate jQuery dependence in a future release (#320). I think most of these changes will still pass, except for my specific mention of jQuery events at one place. I suppose the event object is going to stay but no longer as a jQuery object? |
Contributor
|
Thanks for this! Yeah, the event object will stay — but the jQuery change is quite a while away and I think there will be a big documentation rework at the same time. |
tgvashworth
added a commit
that referenced
this pull request
Jan 16, 2015
Update Advice API doc for event and data params, multiple advice
Contributor
|
Thanks! |
Contributor
Author
|
I missed updating the Readme. Looks like I'll need to creater another PR. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation to go with #299.