Skip to content

maint: bump cibuildwheel, mpfr and flint #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oscarbenjamin merged 3 commits into from
May 25, 2025
Merged

maint: bump cibuildwheel, mpfr and flint #283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44c8258
maint: bump cibuildwheel to 3.0.0b1
oscarbenjamin May 25, 2025
fb32588
Remove outdated comments
oscarbenjamin May 25, 2025
bf24cfa
Bump mpfr and flint versions
oscarbenjamin May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/buildwheel.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
if: ${{ matrix.os == 'windows-2019' }}

- name: Build wheels
uses: pypa/cibuildwheel@d04cacbc9866d432033b1d09142936e6a0e2121a # v2.23.2
uses: pypa/cibuildwheel@90a0ddeff0f23eebc21630e65d66d0f4955e9b94 # v3.0.0b1
env:
# override setting in pyproject.toml to use msys2 instead of msys64 bash
CIBW_BEFORE_ALL_WINDOWS: msys2 -c bin/cibw_before_all_windows.sh
Expand Down Expand Up @@ -84,8 +84,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-24.04, ubuntu-24.04-arm, windows-2019, macos-13, macos-14]
# This list to be kept in sync with cibuildwheel config
# and python-requires in pyproject.toml.
# This list to be kept in sync with python-requires in pyproject.toml.
python-version: ['3.11', '3.12', '3.13', '3.13t', 'pypy3.11']

steps:
Expand Down Expand Up @@ -171,7 +170,7 @@ jobs:
fail-fast: false
matrix:
# Supported Flint versions:
flint-tag: ['v3.0.1', 'v3.1.3-p1', 'v3.2.0-rc1']
flint-tag: ['v3.0.1', 'v3.1.3-p1', 'v3.2.2']
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
Expand Down
4 changes: 2 additions & 2 deletions bin/build_variables.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ MPIRVER=3.0.0 # MPIR build no longer works (not clear where to download from)

# These are the actual dependencies used (at least by default):
GMPVER=6.3.0
MPFRVER=4.1.0
FLINTVER='3.2.0'
MPFRVER=4.2.2
FLINTVER='3.2.2'
9 changes: 3 additions & 6 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "python-flint"
description = "Bindings for FLINT"
version = "0.7.1"
# This needs to be in sync with README, cibuildwheel and CI config.
# This needs to be in sync with README, and CI config.
requires-python = ">= 3.11"
authors = [
{name = "Fredrik Johansson", email = "fredrik.johansson@gmail.com"},
Expand Down Expand Up @@ -80,13 +80,10 @@ package = "flint"
]

[tool.cibuildwheel]
# requires-python needs to keep in sync with this and also the list of Python
# versions the wheels are tested against in CI.
build = "cp311-* cp312-* cp313-* cp313t-* pp311-*"
skip = "*-win32 *-manylinux_i686 *-musllinux_*"
skip = "*-win32 *-manylinux_i686 *-manylinux_armv7l *-musllinux_*"

# Enable building for free-threaded CPython builds
enable = ["cpython-freethreading"]
Copy link

@mayeut mayeut May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The environment variable & toml setting are additive for enable, it might be better to keep the static config in pyproject.toml and only add cpython-prerelease in the workflow (you can also add a condition on tags if you don't want to forget to remove it before a release).

Copy link
Collaborator Author

@oscarbenjamin oscarbenjamin May 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I don't think I want to have cpython-prerelease there at all actually (now that I have already confirmed that it works). For a moment it seemed like a good way to keep up to date with changes in 3.14 but actually I think it would be better just to have a job that builds fresh rather than messing with the wheel building configuration.

enable = ["cpython-freethreading", "pypy"]

manylinux-x86_64-image = "manylinux2014"
manylinux-aarch64-image = "manylinux_2_28"
Expand Down
Loading