CI: test all available OS in CI #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Unfortunately windows-2019 is not usable today: I think after today there is a week left in which windows-2019 is still available so will make sure to put out a release in that time. |
Collaborator
Author
Collaborator
Author
|
Okay great. This seems to work fine on all Windows OS using the wheels built on windows-2019 which are like the wheels uploaded to PyPI. We can't continue building on windows-2019 though because it will be removed from GA in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up from gh-290.
It seems that the wheels built in CI on windows-2019 runners fail on windows-2022 runners. This PR just makes sure that the built wheels are tested on all versions of Windows, MacOS and Ubuntu available as standard GitHub Actions runners. I expect then that the windows-2022 and windows-2025 jobs here will fail.
Afterwards I'll test the effect of trying to build on a different Windows version.