build: enable building with the limited API #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cython 3.1 makes it possible to build with the limited API. This adds the necessary build configuration so that python-flint can be built with the limited API which in principle makes it possible to have abi3 wheels that can work with a range of CPython versions. Although this builds the tests crash pretty quickly in a segfault so more work would be needed to make these builds useful. For now we just enable this as an experimental build mode. When it is working it would be worth running some timings to see if it is slower than a normal build.
oscarbenjamin
force-pushed
the
pr_limited_api
branch
from
8fe156e to
3c13818
Compare
Collaborator
Author
|
The limited API build does not work right now: $ rm -r build build-install/
$ meson setup build -Dpython.allow_limited_api=true
$ spin test
...
build-install/usr/local/lib/python3.13/site-packages/flint/test/test_all.py Fatal Python error: Segmentation fault
$ spin run python -m flint.test
...
Running tests...
test_pyflint...
(segfault)The segfault is pretty immediate: In [1]: import flint
In [2]: flint.fmpz() == flint.fmpz(0)
Segmentation fault (core dumped)I'm not sure if that is something that can be fixed in python-flint or just a bug in Cython though. For now we can merge the build option for further testing though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cython 3.1 makes it possible to build with the limited API. This adds the necessary build configuration so that python-flint can be built with the limited API which in principle makes it possible to have abi3 wheels that can work with a range of CPython versions.
Although this builds the tests crash pretty quickly in a segfault so more work would be needed to make these builds useful. For now we just enable this as an experimental build mode. When it is working it would be worth running some timings to see if it is slower than a normal build.