Use Sanitize on actor_names #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkeepers
approved these changes
Jan 6, 2024
Collaborator
bkeepers
left a comment
bkeepers
left a comment
There was a problem hiding this comment.
Thanks for the PR. It would be great to have a test for this too. Let me know if you want help adding that.
Collaborator
|
@bryszard 1.2.0 is out with this change. Thanks for your help! https://blog.flippercloud.io/flipper-1-2-0/ |
Contributor
Author
|
Thank you for writing tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue - #805
Motivation & context
As pointed out in the issue, there is currently an inconsistency between how we treat on the UI some elements (eg.
Flipper::UI.configuration.banner_text,@feature.description) and how we treat the@feature.actor_names.The real world use case is making the actor names clickable as links to the resources that are the actors.
I've done the simplest possible change, not changing anything about the content itself.
Changes
Sanitize.fragmentto the"#{@feature.actor_names[item]} (#{item})"onfeature.erbVisual QA