Skip to content

Add confirmation dialog before disabling a flipper #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bkeepers merged 2 commits into from
Jan 10, 2024
Merged

Add confirmation dialog before disabling a flipper #813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1d6506
Add disable confirmation
Jan 9, 2024
3d74ab3
Whitespace
Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/flipper/ui/configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ class Configuration
# Default is false.
attr_accessor :confirm_fully_enable

# Public: if you want to get a confirm pop up box while disabling a feature
# Default is false.
attr_accessor :confirm_disable

VALID_BANNER_CLASS_VALUES = %w(
danger
dark
Expand Down Expand Up @@ -91,6 +95,7 @@ def initialize
@show_feature_description_in_list = false
@actors_separator = ','
@confirm_fully_enable = false
@confirm_disable = true
@read_only = false
end

Expand Down
13 changes: 12 additions & 1 deletion lib/flipper/ui/public/js/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,18 @@ $(function () {
e.preventDefault();
}
});


$("#disable_feature__button").on("click", function (e) {
const featureName = $(e.target).data("confirmation-text");
const promptMessage = prompt(
`Are you sure you want to disable this feature for everyone? Please enter the name of the feature to confirm it: ${featureName}`
);

if (promptMessage !== featureName) {
e.preventDefault();
}
});

$("#delete_feature__button").on("click", function (e) {
const featureName = $(e.target).data("confirmation-text");
const promptMessage = prompt(
Expand Down
9 changes: 7 additions & 2 deletions lib/flipper/ui/views/feature.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,13 @@

<% unless @feature.off? %>
<div class="col">
<button type="submit" name="action" value="Disable" class="btn btn-outline-danger btn-block">
<span class="d-block" data-toggle="tooltip" title="Disable for everyone by clearing all percentages, groups and actors.">
<button type="submit" name="action" value="Disable" <% if Flipper::UI.configuration.confirm_disable %>id="disable_feature__button"<% end %> class="btn btn-outline-danger btn-block">
<span class="d-block" data-toggle="tooltip"
<% if Flipper::UI.configuration.confirm_disable %>
data-confirmation-text="<%= feature_name %>"
<% end %>
title="Disable for everyone by clearing all percentages, groups and actors."
>
Disable
</span>
</button>
Expand Down