Skip to content

Adjust minimum poll and sleep interval for Cloud #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnunemaker merged 2 commits into from
Feb 14, 2024
Merged

Adjust minimum poll and sleep interval for Cloud #841

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7482dfd
Set minimum interval to 10
jnunemaker Feb 14, 2024
2fb4cb9
More sleep time between polls
jnunemaker Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/flipper/poller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ def self.reset
instances.each {|_, instance| instance.stop }.clear
end

MINIMUM_POLL_INTERVAL = 10

def initialize(options = {})
@thread = nil
@pid = Process.pid
Expand All @@ -30,9 +32,9 @@ def initialize(options = {})
@last_synced_at = Concurrent::AtomicFixnum.new(0)
@adapter = Adapters::Memory.new(nil, threadsafe: true)

if @interval < 1
warn "Flipper::Cloud poll interval must be greater than or equal to 1 but was #{@interval}. Setting @interval to 1."
@interval = 1
if @interval < MINIMUM_POLL_INTERVAL
warn "Flipper::Cloud poll interval must be greater than or equal to #{MINIMUM_POLL_INTERVAL} but was #{@interval}. Setting @interval to #{MINIMUM_POLL_INTERVAL}."
@interval = MINIMUM_POLL_INTERVAL
end

@start_automatically = options.fetch(:start_automatically, true)
Expand Down Expand Up @@ -64,8 +66,7 @@ def run
# you can instrument these using poller.flipper
end

sleep_interval = interval - (Concurrent.monotonic_time - start)
sleep sleep_interval if sleep_interval.positive?
sleep interval
end
end

Expand Down