adds race_condition_ttl option for the ActiveSupportCacheStore adapter #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
howdy, I wanted to check-in to see how to get this PR reviewed. thanks |
Collaborator
|
Great PR! Thanks @rosanelli! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the Flipper ActiveSupportCacheStore adapter by introducing support for the :race_condition_ttl option in the underlying Rails.cache operations.
The :race_condition_ttl option is a native feature of ActiveSupport::Cache::Store, designed to help mitigate cache stampedes, a situation where many concurrent requests simultaneously regenerate an expired cache entry, potentially overloading the backend.
By exposing this option through the Flipper adapter, users can configure their feature gate caching to be more resilient under heavy load, especially for high-throughput applications that rely on feature flags and frequent polling of cache-backed configurations.