Skip to content
This repository was archived by the owner on Jun 24, 2025. It is now read-only.

Update to newest vinyl for gulp 4 support#296

Merged
floatdrop merged 1 commit intofloatdrop:masterfrom
phated:patch-1
Jan 7, 2018
Merged

Update to newest vinyl for gulp 4 support#296
floatdrop merged 1 commit intofloatdrop:masterfrom
phated:patch-1

Conversation

@phated
Copy link
Copy Markdown
Contributor

@phated phated commented Dec 22, 2017

@UltCombo can you get this merged and published right away? A lot of people are having trouble with the new alpha of gulp 4 due to outdated vinyl deps.

@erikkemperman
Copy link
Copy Markdown

Need to check why tests are failing, but +1 for the vinyl upgrade!

@namoscato
Copy link
Copy Markdown

It looks like the AppVeyor failure is caused by the latest version of npm@5.6.0 running on an older version of Node v0.12. While I did not test this on Windows, I was able to replicate the issue on my MacBook, and the issue was resolved by downgrading to npm@2.15.11, which is bundled with Node v0.12.

I am unfamiliar with AppVeyor, but we might look at removing:

- npm -g install npm@latest

The Travis CI ENOSPC failures seem to point to resource constraints and relate to gulpjs/gulp#217 / stackoverflow.com/q/16748737.

@phated
Copy link
Copy Markdown
Contributor Author

phated commented Dec 26, 2017

@namoscato We've been using npm@^3 for gulp projects.

@phated
Copy link
Copy Markdown
Contributor Author

phated commented Dec 26, 2017

@floatdrop @UltCombo any word on when this will get updated?

@floatdrop
Copy link
Copy Markdown
Owner

floatdrop commented Dec 27, 2017

@phated we need to check why ENOSPC happens – tests are not watching so many files. (just started build again, and it's passed – may be travis wierd bug)

@floatdrop
Copy link
Copy Markdown
Owner

Gulp.js is still on 3.9.1 version, so we can publish updated vinyl only on latest tag (as gulp does).

@phated
Copy link
Copy Markdown
Contributor Author

phated commented Dec 27, 2017

Vinyl 2.1 is released as latest and is backwards compatible. This needs to get updated because the gulp 4 release is only a few days away.

@floatdrop
Copy link
Copy Markdown
Owner

Vinyl 2.1 is released as latest and is backwards compatible. This needs to get updated because the gulp 4 release is only a few days away.

@phated I understand that, but still this should be released as major bump or with custom tags. I'm preferring bumping major versions for this. @UltCombo any thoughts on this?

@phated
Copy link
Copy Markdown
Contributor Author

phated commented Dec 27, 2017

I think bumping major is good. But you probably want to wait for the upcoming chokidar v2 then. I'll be working on that tomorrow.

@phated
Copy link
Copy Markdown
Contributor Author

phated commented Dec 31, 2017

@floatdrop chokidar bumped to 2.0 the other day. Want to get that + vinyl 2.1 merged into master and major bump?

@phated
Copy link
Copy Markdown
Contributor Author

phated commented Jan 4, 2018

Ping again @floatdrop

@floatdrop floatdrop merged commit 02bd06d into floatdrop:master Jan 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants