Conversation
…lein#115) * making expenses optional and adding items support for vendor_bill * adding test
csrbarber
reviewed
Jan 2, 2024
| else: | ||
| exc = self._request_error('upsert', detail=status['statusDetail'][0]) | ||
|
|
||
| if record_type: |
There was a problem hiding this comment.
It looks like this second param is only for error parsing. I think upsertList should be unaffected by this. We just won't get the benefits of whatever this does.
There was a problem hiding this comment.
I don't like the way this is implemented anyhow. You could pass "journal_entry" as the second param in an upsert to a Bill. I wonder what happens then.
csrbarber
reviewed
Jan 2, 2024
| 'memo', | ||
| 'tranDate', | ||
| 'tranId', | ||
| 'itemList', |
There was a problem hiding this comment.
Looks like the changes here are to support customFields for items. We don't use item based lines, so we're in the clear. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had merge conflicts in vendor bills that need to be looked at closely.
I also notice that the upsert calls are providing a second parameter. Will need to figure out if this is required for upsert_list as well.