Use prependLocation() instead of addLocation() to allow overriding theme after boot#36
Use prependLocation() instead of addLocation() to allow overriding theme after boot#36kirkbushell merged 2 commits intofloatingpointsoftware:masterfrom darron1217:allow-overriding
Conversation
|
@kirkbushell Ping |
|
@darron1217 it is, just a bit busy is all. Thanks for this, will test, merge then release. |
|
@kirkbushell Okay |
|
@kirkbushell Ping This PR only changes the order of view. It makes laravel reads the first matching view So I changed method into No laravel reads the first matching view |
|
@kirkbushell Ping |
|
Thanks @darron1217 . Apologies, lots going on atm - I'll get to this tonight. Thanks again. |
|
Was there any problem about this PR? |
|
@darron1217 yes. Tests fail. prependLocation doesn't even seem like it's available. I think it needs a laravel update, which I'll look into. |
|
Okay.. I found the reason https://laravel.com/api/5.4/Illuminate/View/FileViewFinder.html#method_prependLocation This method is available from version 5.4 |
|
Line 17 in 5b13552 We must change this line into |
|
Yeah, I tried a few different versions but cannot update to that version just yet. 5.4 is a long way from 5.0, which is where this package was sitting. I've brought it up to 5.1, as I believe that's an LTS release, and I'll release another update for 5.4 and above in a separate version chain so you can use it right away. |
|
@kirkbushell Okay then |
|
Yup, I'll do exactly that but it will need to wait until later tonight. Thanks for being patient :) |
|
Anyway, I realized that laravel 5.5 is LTS (Also php version constraint has changed to 7 on this version) |
|
Yup, sounds good to me :) |
Related to #35