LIVE-6815: Image-based trick-play and more#9
Merged
AndrewBird81 merged 5 commits intomasterfrom Apr 23, 2025
Merged
Conversation
- Removing the `isIFrameOnly` and `isIFrame` booleans from Rendition and MediaPlaylist - Adding support for image-based trickplay playlists - Adding type safety to stringify and parse - Adding iterators and transformers to MediaPlaylist - Type fixes - a type-safe parser for MediaPlaylists and MasterPlaylists - Test fixes
AndrewBird81
requested review from
Danglebary,
asoulliereHT,
bryglen and
junievi
| IFrame = 'EXT-X-IMAGES-ONLY', | ||
| Image = 'EXT-X-I-FRAMES-ONLY', | ||
| IFrame = 'EXT-X-I-FRAMES-ONLY', | ||
| Image = 'EXT-X-IMAGES-ONLY', |
Author
There was a problem hiding this comment.
I didn't love it either, but I couldn't think of a better way. I didn't want to make it MediaPlaylist<T extends SomeType> because that'd result in massive code changes everywhere we use the library. All we really care about is the convenience getters isStandardPlaylist, isIFramePlaylist and isImagePlaylist
harrietfigueroa
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looks huge, but only a bit of it is interesting
isIFrameOnlyandisIFramebooleans from Rendition and MediaPlaylist