Skip to content

Conversation

@rikner
Copy link
Contributor

@rikner rikner commented Mar 15, 2021

Fixes #

Type of change:

Motivation (current vs expected behavior)

Update swift-jni to the latest devel-branch, which has some API enhancements that are handy (e.g. direct access to Java buffer types).
see: SwiftAndroid/swift-jni#18

Please check if the PR fulfills these requirements

  • Self-review: I am confident this is the simplest and clearest way to achieve the expected behaviour
  • There are no dependencies on other PRs or I have linked dependencies through Zenhub
  • The commit messages are clean and understandable
  • Tests for the changes have been added (for bug fixes / features)

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #325 (608674d) into master (dede1ce) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #325   +/-   ##
=======================================
  Coverage   51.22%   51.22%           
=======================================
  Files          87       87           
  Lines        2899     2899           
=======================================
  Hits         1485     1485           
  Misses       1414     1414           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dede1ce...608674d. Read the comment docs.

@rikner rikner requested review from ephemer and michaelknoch March 15, 2021 11:43
@rikner rikner merged commit 27b83c3 into master Mar 15, 2021
@rikner rikner deleted the update-swift-jni branch March 15, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants