Appropriate client methods are now const #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexHarker
force-pushed
the
parameter-set-const-correctness
branch
from
49b79b7 to
d7c9347
Compare
Contributor
Author
|
Thanks @weefuzzy - are you happy with the further additions before I merge? The most salient one is the enable_if_t refactor (I couldn't get the method const any other way). This was suggested by @lewardo as an alternative incantation, but I cannot say I ever really feel I understand the details of std::enable_if_t |
AlexHarker
changed the title
Member
|
Should be equivalent 😬 I think the difference is in the context in which the method is enabled / disabled, so that in the first case it was too 'late' to be consty. Or something. |
Contributor
Author
|
@tremblap - these changes are pretty minimal (there are a lot, but they shouldn't do anything and if they did the compiler should test them) but given the number can you give them a spin in your preferred methods before merging? |
jamesb93
pushed a commit
to jamesb93/flucoma-core
that referenced
this pull request
Aug 16, 2023
* Methods applying constraints are now const * Const correctness for further applyConstraint(s) / descriptorAt() methods * algorithm and client latency() or initialized() should be const * Appropriate client methods made const
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is desirable as it allows differentiation outside of the client / parameter set of what will touch object state (which applying constraints does not).
This will aid in reasoning about threading things in other places.