remove the data folder being copied in the dev packaging #27
Conversation
tremblap
requested review from
jamesb93 and
weefuzzy
and removed request for
jamesb93
|
I think I understand the problem, the repo folder itself doesn't carry the same structure as the |
|
I work in the repo, and that is why I need (git ignored) copies of media+data in /help - the help isn't found as in a real install but at least I can work on the right file structure. I think I prefer my 2nd option - adding back the copy that was faulty, putting it in the right place (in help) and copying too the audio at the same time and the same place. If @weefuzzy approves I'll do that and push and merge |
|
I have a bunch of handmade symlinks for working with PD during development, which isn't ideal either, however, that's mostly due to the handmade-ness. A suggestion: if we bump the min CMake version to 3.14 (current version is 3.22) then we can make symlinks at configure time, meaning that we could have CMake synthesise and maintain a viable working environment for externals, help and resources |
|
this sound erotic. What are the potential pitfalls of cmake bump? |
|
Very few compared to the status quo, I think. For a long while (maybe even now), the version in the default |
|
I just noticed that this is more important than I thought, since the mess of development in pd made us forget the concataudiofile in the last 2 beta. @weefuzzy let's spend a few minutes together to brainstorm a good dev folder structure soon-ish. |
* nightlies workflow * use PD_PATH flag * use the pd binaries on msp * dont use powershell in unix * fix borked ls * point to the right sdk * make release builds on windows * remove pdb file filter * use dev core * delete release before uploading the new one * abstraction added to convert string back to float * giving credit (#11) * rename tag * provide the proper fluid path for mac builds * provide the proper fluid path for the other 2 CCE's * clone core not sc... 🤦♂️ * Add handling for MLP read methods to wrapper (#10) * cleaned structure and copy of abstractions * add docs to PD CI * add pd path * use a macos runner for docs * correct the name for Windows .zip * [CI] Refactor and use composite actions (#13) * use flucoma actions instead of horrid code * use more composite actions where possible * remove extraneous -name: * try a different folder structure out * move one level up for packaging * demoaudiofiles abstraction for the helpfiles * added fluid.demosound~ * move to v4 of actions * also update docs * cosmetic changes to improve readability * chroma help update * remove weird magic number fixes #18 * correct order of variables in PDBufferAdaptor error message fixes #17 * corrections in progress * chroma new format * bufchroma done * changing spaces for underlines for enhanced readability * use new action for building docs * use ubuntu to build docs * update release workflow * add support for core #88 * copy to datasets path * ignore data * copy resources data on cmake configure * change source1 to sourcea and source2 to sourceb * add workflow dispatch to nightly * correct docs install source * optional args: add to wrapper * Wrapper: Add choices param (symbol list -> bitset) * fix the missing ; at the end of the updated file names * Add feature objects for slicers (#35) * Add feature objects for slicers * onsetfeature help file * rt feature help files * remove thing about pianos * add buffer feature help files * @Algorithm * fixing the helpfiles * expanded onsetfeature * norveltyfeature fixed * ampfeature fixed * fixed bufampfeature * bufnoveltyfeature corrected * fix bufonsetfeature * corrected range for onsetfeature viewer * ignore more permutations of build folder * PDWrapper: deal with some warnings * FluidTensorView copy updates * changing preset and interface for noveltyslice examples * new overview including all data objects * PDBufferAdaptor: Add redraw() and call on release() * remove the data folder being copied in the dev packaging (#27) * concataudiofile and it help merged in dev * `ControlIn` objects – properly adjust `ac` when adjusting `av` – ensure mListSize is always intialized to something * Enhance/max params (#44) * CMake: Centralise C++ version and set to 17 * Wrapper: Handle new LongRuntimeMax parameter type * Wrapper: unused variable * Wrapper: add `max<blah>` parameter to PD object for `LongRuntimeMaxT` fixes #45 * updated helpfiles for scalers to include and test inversetransform(point) * Wrapper: fix argument count and warning printer * Wrapper: update for `maxFFTSize` * Wrapper: fix reset for shared objects * Wrapper: use raw maxFFT in FFT setter * Wrapper: fix logic for max params * Wrapper: sort max FFT logic, fixes #48 * Enhance/generate stubs (#49) * CMake: Generate .cpp stubs * CMake remove old cpp stubs and scripts * CMake add Utiltiy for making a working folder of symlinks for dev work * Placate MSVC * CMake: properly invoke docs * CMake: install prefix is a cache variable * CMake: Tidy up * CMake: typo * CI: update nightly workflow * CI: remember to use correct branches * CI: remove reference to docs job * CMake: belatedly add branch selection for flucoma deps upon which CI relies * CI: Correct name of Linux build artefact * help upgrade: first batch Martin * help upgrade: Martin's 2nd batch * help review: martin 3rd batch * help - typo in filename * CMake: fix installation path for externals, fixes #50 Repeat after me: don't just paste from the Max one * CMake: Pick up client tags for finer tilde control * Enhance/managed objects (#47) * Wrapper: Add managed buffers and message outptus * Wrapper: Update outlets for list input * Wrapper: Fix outlet reference for buffer completion * Add header for bufinfo * Add C++ stub for bufinfo * Managed arrays: shrink collection when needed * Update include/FluidPDWrapper.hpp Remove leftover debugging `post()` * BufferAdaptor: Ensure dirty flag is properly initialised * Wrapper: Stop hosted buffers vector reallocating and breaking pointers * updated helpfiles for new interface * bufinfo help * PD Wrapper: Quite possibly fix a double free problem for multiple inlets. * PDWrapper: data objects respond from right outlet for read, write etc * dataset objects: update with right outlet behaviour Co-authored-by: tremblap <info@pierrealexandretremblay.com> * Wrapper: Cheer up MSVC * PDWrapper: Try to swerve around GCC linking sadness * CMake: Add local target for `fluid.bufinfo` * FluidBufInfo: Missing include * PDWrapper: Redo inlet proxies for less crashing * kdtree - added 2nd tab * kdtree 3rd tab added * kdtree fix * BufNNDSVD -> BufNMFSeed (#57) * change filename * change content * typo in help report of bufferadaptor * token skmeans entry and addition to overview (#59) * [Enhance] Update Release Workflow (#60) * update extension to be normalised * cleanup * update release * remove workflow disptach variables * fix release * Update release.yml * Update release.yml * Update release.yml * Update release.yml
This removes a copy that is not needed, or at least in the wrong place to be useful.
What could be done is put that copy in /help (and do the same with audiofiles) so it duplicates the delivery package file structure, and both help/media and help/data are gitignored. I actually do that manually at the moment.
I'm happy to change this PR to this plan B or just remove as proposed now since this top level is just not usable for relative path file retrieval (which is used throughout the help file design)