out_cloudwatch_logs: Added StorageResolution support for EMF#10398
Open
devin-andrenam wants to merge 1 commit intofluent:masterfrom
Open
out_cloudwatch_logs: Added StorageResolution support for EMF#10398devin-andrenam wants to merge 1 commit intofluent:masterfrom
devin-andrenam wants to merge 1 commit intofluent:masterfrom
Conversation
cosmo0920
requested changes
May 30, 2025
Comment on lines
+212
to
+213
| if (tmp) | ||
| { | ||
| flb_plg_info(ctx->ins, "Metric Storage Resolution=%s", tmp); | ||
| ctx->metric_storage_resolution = atoi(tmp); | ||
| } else { |
Contributor
There was a problem hiding this comment.
These lines could be violated for the coding guide line:
https://github.com/fluent/fluent-bit/blob/master/CONTRIBUTING.md#coding-style
Author
There was a problem hiding this comment.
Updated formatting.
And correct. As cpu and mem are not considered metrics, this will only apply to them. May be outside the scope of this PR but does bring up the issue of whether cpu and mem should be updated to be metrics or kept as logs.
Member
|
ping @sparrc @singholt @swapneils |
Signed-off-by: Devin Stafford <devin@andrenam.com>
devin-andrenam
force-pushed
the
devin-master-cloudwatch-storage-resolution
branch
from
4cfca0c to
cd82c37
Compare
Author
|
Bump on the review requests. @PettitWesley @singholt @swapneils @sparrc |
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following PR adds support for StorageResolution for CloudWatch metrics. This tunable allows users to indicate to CloudWatch the expected granularity to store the metrics. See the following CloudWatch documentation for details.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
The following images illustrate the correctness of the raw EMF logs as well as its sub 60s resolution at the metric graphing level.
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Documentation PR
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.