Skip to content

packaging: script: Use rockylinux prefix on package testing script#11297

Merged
patrick-stephens merged 1 commit intomasterfrom
cosmo0920-use-rockylinux-prefix-on-release-package-test-script
Dec 19, 2025
Merged

packaging: script: Use rockylinux prefix on package testing script#11297
patrick-stephens merged 1 commit intomasterfrom
cosmo0920-use-rockylinux-prefix-on-release-package-test-script

Conversation

@cosmo0920
Copy link
Copy Markdown
Contributor

@cosmo0920 cosmo0920 commented Dec 18, 2025

For safety, we should use rockylinux/ prefix for testing package installations on rockylinux.
Rockylinux 8 and 9 are already existing in library prefix which is the default prefix of Docker pulling destination but rockylinux 10 is not there.
Plus, for simplicity of maintenance, just align the usage of container names with package building containers of rockylinux.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated container image references in the release packaging pipeline to support Rocky Linux 8, 9, and 10.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: Hiroshi Hatake <hiroshi@chronosphere.io>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Dec 18, 2025

Walkthrough

This pull request updates Docker image references in the package test script by changing Rocky Linux image namespaces from rockylinux:8/9/10 to rockylinux/rockylinux:8/9/10 in the YUM_TARGETS array, ensuring test harnesses use the correct image identifiers.

Changes

Cohort / File(s) Summary
Rocky Linux image reference updates
packaging/test-release-packages.sh
Updated YUM_TARGETS entries to use fully-qualified Docker image namespaces for Rocky Linux 8, 9, and 10 (rockylinux/rockylinux instead of rockylinux)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single file with straightforward string reference updates
  • No logic, control flow, or functional behavioral changes
  • Minimal context needed; change is self-evident

Possibly related PRs

Suggested labels

ok-package-test

Suggested reviewers

  • niedbalski
  • celalettin1286

Poem

🐰 A namespace aligned, so neat and tight,
Rocky images now in their rightful sight,
From rockylinux to rockylinux/rockylinux they fly,
Tests shall pass with nary a sigh! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: updating the package testing script to use the 'rockylinux/' image prefix for Rocky Linux containers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cosmo0920-use-rockylinux-prefix-on-release-package-test-script

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 909b1a9 and b201057.

📒 Files selected for processing (1)
  • packaging/test-release-packages.sh (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Run install tests
🔇 Additional comments (1)
packaging/test-release-packages.sh (1)

54-56: The change to use rockylinux/rockylinux namespace for all Rocky Linux versions is correct and necessary.

The official Docker Hub documentation only lists versions 8 and 9 for the library prefix, meaning Rocky Linux 10 is only available as rockylinux/rockylinux:10. The rockylinux/rockylinux namespace is the official Rocky Linux image, and this change maintains consistency across all supported versions while enabling Rocky Linux 10 support.

The updated image references are accessible and valid for use.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cosmo0920
Copy link
Copy Markdown
Contributor Author

Now, all of the installation tests are passed in our CI. 🎉

https://github.com/fluent/fluent-bit/actions/runs/20328282293/job/58397830105?pr=11297

@patrick-stephens patrick-stephens merged commit 702f4f1 into master Dec 19, 2025
19 checks passed
@patrick-stephens patrick-stephens deleted the cosmo0920-use-rockylinux-prefix-on-release-package-test-script branch December 19, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants