yum: generate build_id in -debuginfo#371
Merged
ashie merged 1 commit intofluent:masterfrom Apr 18, 2022
Merged
Conversation
build_id links may be useful for debug but there is a case that build_id conflicts with other packages. (e.g. gitlab-ce) Thus "_build_id_links compat" may not be suitable, so change it to traditional alldebug. Before: td-agent contains /usr/lib/debug/.build-id/xx/yy After: td-agent-debuginfo contains /usr/lib/debug/.build-id/xx/yy NOTE: rpm --excludepath may be a workaround to install, but it is not so good. Closes: fluent#370 Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
ashie
approved these changes
Apr 18, 2022
|
Thanks for resolving this! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_id links may be useful for debug but there is a case that
build_id conflicts with other packages. (e.g. gitlab-ce)
Thus "_build_id_links compat" may not be suitable, so change it to
traditional alldebug.
Before:
td-agent contains /usr/lib/debug/.build-id/xx/yy
After:
td-agent-debuginfo contains /usr/lib/debug/.build-id/xx/yy
NOTE: rpm --excludepath may be a workaround to install, but it is not
so good.
Closes: #370