rpm: add confluent (kafka) test case#661
Merged
kenhys merged 11 commits intofluent:masterfrom Jul 29, 2024
Merged
Conversation
kenhys
force-pushed
the
rpm-confluent-test
branch
3 times, most recently
from
124661c to
3a7e71e
Compare
kenhys
force-pushed
the
rpm-confluent-test
branch
7 times, most recently
from
ab4b9e9 to
00a11df
Compare
Contributor
Author
|
NOTE enable serverspec recipe again. |
kenhys
force-pushed
the
rpm-confluent-test
branch
4 times, most recently
from
d31a847 to
fb07623
Compare
Contributor
Author
|
kafka spec is not properly executed yet. |
kenhys
force-pushed
the
rpm-confluent-test
branch
4 times, most recently
from
a2d0a85 to
447f6e3
Compare
Contributor
Author
|
hmm, confluent test case with deb succeeds, but not for rpm. |
kenhys
force-pushed
the
rpm-confluent-test
branch
from
447f6e3 to
32e08a2
Compare
Contributor
Author
|
Should be rebased after #665 was merged. |
kenhys
force-pushed
the
rpm-confluent-test
branch
4 times, most recently
from
b3683a4 to
7631ab3
Compare
Contributor
Author
|
got it. needless limitation of CentOS 8 Stream era blocked it. |
kenhys
force-pushed
the
rpm-confluent-test
branch
from
7631ab3 to
ef4cdd9
Compare
Contributor
Author
|
macOS failure is out of scope: See #666 |
Contributor
Author
|
just recheck it again. |
kenhys
force-pushed
the
rpm-confluent-test
branch
from
761bb1d to
3ee01c5
Compare
Contributor
Author
|
Fixed unexpected failure on debian. |
daipom
reviewed
Jul 29, 2024
Contributor
daipom
left a comment
daipom
left a comment
There was a problem hiding this comment.
Thanks!
I commented on a few points of concern.
test packaged rdkafka usability. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
And raise baseline of OpenJDK version and Confluent. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kafka related test case was extracted into confluent-test.sh. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
In the past versions, CentOS 8 Stream should be excluded, but there is no such a exception. Instead, it is harmful that serverspec test case is not executed. so just replace it. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
In the past versions, CentOS 8 Stream should be excluded, but there is no such a exception. Instead, it is harmful that serverspec test case is not executed. so just replace it. Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
rpm-confluent-test
branch
from
3ee01c5 to
74ee44f
Compare
Contributor
Author
|
Fixed based on feedback. |
daipom
reviewed
Jul 29, 2024
As we need to handle *whole string" as input, using $0 is correct. (though as it doesn't contains separator, $0/$1 seems same for awk) Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
kenhys
force-pushed
the
rpm-confluent-test
branch
from
74ee44f to
d81f8b7
Compare
Contributor
Author
|
waiting CI to be sure. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test packaged rdkafka usability.