rpm: fix update error if working directory is missing#955
rpm: fix update error if working directory is missing#955Watson1978 wants to merge 10 commits intofluent:masterfrom
Conversation
ca11a50 to
db58633
Compare
db58633 to
49a74ea
Compare
kenhys
left a comment
There was a problem hiding this comment.
I come to think using /tmp/fluent is bad design failure.
So, it might be better to switch using /var/cache/fluent or something instead.
What do you think?
(If already /var/cache/fluent is used by user, need to care that too)
|
That makes sense. In additional, maybe we should replace /tmp/fluent/.main_pid into /var/run/fluent.main_pid or other. |
I did miss read. |
1e6d6e9 to
c942015
Compare
6786caf to
b4214a6
Compare
b4214a6 to
59de94a
Compare
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
- Switch from /tmp/fluent to /var/cache/fluent for upgrade-related files. - This avoids issues where /tmp is cleaned by systemd-tmpfiles or accidentally modified by users. - Ensures the directory exists during the package upgrade process. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
59de94a to
6b5e6ed
Compare
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
7e55233 to
501a445
Compare
kenhys
left a comment
There was a problem hiding this comment.
Could you add test case for downgrading to v6.0.0 or v6.0.1?
something like downgrade-to-v6-lts-tmpfiles.sh
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
ec73fdb to
100fbe1
Compare
If
/tmp/fluent/was removed, it causes error when update to Fluent Package 6.0.x as following: