Skip to content

in_debug_agent: accept only from local machine by default#5272

Merged
kenhys merged 1 commit intofluent:masterfrom
kenhys:debug-agent-localhost
Mar 10, 2026
Merged

in_debug_agent: accept only from local machine by default#5272
kenhys merged 1 commit intofluent:masterfrom
kenhys:debug-agent-localhost

Conversation

@kenhys
Copy link
Contributor

@kenhys kenhys commented Mar 10, 2026

Which issue(s) this PR fixes:
Fixes #

What this PR does / why we need it:

Usually, in_debug_agent must be explicitly enabled by users who know what you do.
But, there is an security concern which accepts external access by default even though user must enable it explicitly.

With this commit, change that behavior a bit secure by default.

Docs Changes:

Need to update default.

https://docs.fluentd.org/monitoring-fluentd/monitoring-rest-api#datadog-dd-agent-integration

Release Note:

N/A

Usually, in_debug_agent must be explicitly enabled by users
who know what you do.
But, there is an security concern which accepts external access by
default even though user must enable it explicitly.

With this commit, change that behavior a bit secure by default.

Signed-off-by: Kentaro Hayashi <hayashi@clear-code.com>
@kenhys
Copy link
Contributor Author

kenhys commented Mar 10, 2026

No need to backport? 🤔

@kenhys kenhys requested review from Watson1978 and ashie March 10, 2026 07:17
Copy link
Contributor

@Watson1978 Watson1978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kenhys kenhys added the backport to v1.19 We will backport this fix to the LTS branch label Mar 10, 2026
@kenhys
Copy link
Contributor Author

kenhys commented Mar 10, 2026

Added fluent/fluentd-docs-gitbook#616 about this change.

@kenhys kenhys merged commit 7a3ebf6 into fluent:master Mar 10, 2026
36 of 37 checks passed
@kenhys kenhys deleted the debug-agent-localhost branch March 10, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport to v1.19 We will backport this fix to the LTS branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants