Skip to content

This PR is to add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_test.go. #5817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fluid-e2e-bot merged 6 commits into from
Apr 29, 2026
+6 −4
Merged

This PR is to add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_test.go. #5817

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f48325
Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_tes…
github2134243 Apr 28, 2026
9a7a848
Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_tes…
github2134243 Apr 28, 2026
74926ef
Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_tes…
github2134243 Apr 28, 2026
2cebf88
Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_tes…
github2134243 Apr 28, 2026
dc96537
Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_tes…
github2134243 Apr 29, 2026
2597bd1
Add comments to GetCommonLabelName in fluid/pkg/ddc/base/validate_tes…
github2134243 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions pkg/ddc/base/validate_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,12 @@ func (m *mockRuntimeInfoForValidate) GetOwnerDatasetUID() string { return m.owne
func (m *mockRuntimeInfoForValidate) IsPlacementModeSet() bool { return m.placementModeSet }

// Conventions interface methods (stub implementations)
func (m *mockRuntimeInfoForValidate) GetPersistentVolumeName() string { return "" }
func (m *mockRuntimeInfoForValidate) GetLabelNameForMemory() string { return "" }
func (m *mockRuntimeInfoForValidate) GetLabelNameForDisk() string { return "" }
func (m *mockRuntimeInfoForValidate) GetLabelNameForTotal() string { return "" }
func (m *mockRuntimeInfoForValidate) GetPersistentVolumeName() string { return "" }
func (m *mockRuntimeInfoForValidate) GetLabelNameForMemory() string { return "" }
func (m *mockRuntimeInfoForValidate) GetLabelNameForDisk() string { return "" }
func (m *mockRuntimeInfoForValidate) GetLabelNameForTotal() string { return "" }

// GetCommonLabelName returns the common label name.
func (m *mockRuntimeInfoForValidate) GetCommonLabelName() string { return "" }
func (m *mockRuntimeInfoForValidate) GetFuseLabelName() string { return "" }
func (m *mockRuntimeInfoForValidate) GetRuntimeLabelName() string { return "" }
Expand Down
Loading