Add support for incoming application control #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
…ouble launch Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
swift-kim
reviewed
Jul 26, 2021
swift-kim
reviewed
Jul 26, 2021
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
swift-kim
reviewed
Jul 27, 2021
* renamings * missing empty lines or dots * changed way of returning extra data * masking of app_control in flutter_tizen_engine.* and flutter_tizen.* files
swift-kim
reviewed
Jul 29, 2021
swift-kim
approved these changes
Aug 2, 2021
Member
swift-kim
left a comment
swift-kim
left a comment
There was a problem hiding this comment.
Hmm, I'll organize #includes later. Otherwise looks good to me.
bbrto21
reviewed
Aug 2, 2021
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* [AppControl] Add support for reading operation from app_control Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add EventChannel and queue for app controls Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add basic operations for AppControl Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Refactor extra data to use EncodableValue Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Refactor HandleMethodCall Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Refactor Event, Send and Terminate logic Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add support for extra data and dispose Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add support for reply Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add support for launch mode and organize logs Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Fix bugs with not saving app control on reply and with double launch Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Update logs and comments Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * Run code formatter Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Fixes after code review Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add missing files Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Changel enums to lowerCase Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [appcontrol] Fixes after review * renamings * missing empty lines or dots * changed way of returning extra data * masking of app_control in flutter_tizen_engine.* and flutter_tizen.* files * [appcontrol] Few more fixes for review * [appcontrol] Removed unnecessary code and initialized poiters with nullptr Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* [AppControl] Add support for reading operation from app_control Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add EventChannel and queue for app controls Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add basic operations for AppControl Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Refactor extra data to use EncodableValue Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Refactor HandleMethodCall Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Refactor Event, Send and Terminate logic Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add support for extra data and dispose Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add support for reply Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add support for launch mode and organize logs Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Fix bugs with not saving app control on reply and with double launch Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Update logs and comments Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * Run code formatter Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Fixes after code review Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add missing files Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Changel enums to lowerCase Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [appcontrol] Fixes after review * renamings * missing empty lines or dots * changed way of returning extra data * masking of app_control in flutter_tizen_engine.* and flutter_tizen.* files * [appcontrol] Few more fixes for review * [appcontrol] Removed unnecessary code and initialized poiters with nullptr Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* [AppControl] Add support for reading operation from app_control Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add EventChannel and queue for app controls Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add basic operations for AppControl Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Refactor extra data to use EncodableValue Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Refactor HandleMethodCall Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Refactor Event, Send and Terminate logic Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add support for extra data and dispose Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add support for reply Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add support for launch mode and organize logs Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Fix bugs with not saving app control on reply and with double launch Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Update logs and comments Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * Run code formatter Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Fixes after code review Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Add missing files Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [AppControl] Changel enums to lowerCase Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> * [appcontrol] Fixes after review * renamings * missing empty lines or dots * changed way of returning extra data * masking of app_control in flutter_tizen_engine.* and flutter_tizen.* files * [appcontrol] Few more fixes for review * [appcontrol] Removed unnecessary code and initialized poiters with nullptr Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com> Co-authored-by: Piotr Kosko/Tizen API (PLT) /SRPOL/Engineer/Samsung Electronics <p.kosko@samsung.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of adding support for incoming application control.
Corresponding flutter-tizen change: flutter-tizen/flutter-tizen#174
Dart part of the plugin is currently in internal f-project repository.