[webview_flutter] Clean up debug code & Organize source #156
Conversation
|
I'd appreciate if you could share the upstream commit you referenced. |
|
Did you just change the code order without actual changes? I think you can split the code into a couple of files if they are from different files. FYI) Here is the class hierarchy I analyzed before: #54 (review) |
Here is Information what you requested
|
I guess It's a good way. I will separate it with its original file. |
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
* webview_flutter_tizen.dart : webview part * platform_view.dart : platform view part imported without modification * platform_view_tizen.dart : custom platform view part Signed-off-by: MuHong Byun <mh.byun@samsung.com>
bwikbs
force-pushed
the
cleanup
branch
2 times, most recently
from
4feff0e to
89d52fd
Compare
|
I tried to divide by file.. but I thought it was too small, so I just divided the |
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
| part of 'webview_flutter_tizen.dart'; | ||
|
|
||
| /// How an embedded platform view behave during hit tests. | ||
| enum PlatformViewHitTestBehavior { |
There was a problem hiding this comment.
The PlatformViewHitTestBehavior enum is already public so I think you don't have to copy it from the framework.
Signed-off-by: MuHong Byun <mh.byun@samsung.com>
|
one more things, how about moving implementation code into src dir |
|
@bbrto21 You're right! thanks!!! 👏 |
3 participants
This is a simple code cleanup to better adapt upstream.