Skip to content

Conversation

@HakkyuKim
Copy link
Contributor

This PR partially syncs the example code of package_info_plus_tizen with that of package_info_plus package. This will be released together with the next notable change.

Context: #150 (comment)

app-facing package and bump up versions.
Copy link
Member

@bwikbs bwikbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty hard to understand context 😄

@HakkyuKim
Copy link
Contributor Author

Basically, the package_info_plus made a breaking change in 1.0.4 by adding a required parameter to the PackageInfo's public constructor:

Before:

PackageInfo({
  required this.appName,
  required this.packageName,
  required this.version,
  required this.buildNumber,
});

After:

PackageInfo({
  required this.appName,
  required this.packageName,
  required this.version,
  required this.buildNumber,
  required this.buildSignature,
});

The example code's pubspec.yml sets package_info_plus dependency to ^1.0.1 which allows the tool to get the highest minor.patch version available in pub dev. In this case, however, the semantic versioning was not honored therefore the example app failed to build itself. The maintainers will release a new patch fixing this problem but I'm just taking the opportunity to update the code.

@bwikbs
Copy link
Member

bwikbs commented Aug 4, 2021

@HakkyuKim I didn't mean that.. Thanks for the detailed explaination! 💯

@HakkyuKim
Copy link
Contributor Author

@bwikbs
Oh okay, my bad. Thanks for a quick review!

@HakkyuKim HakkyuKim merged commit b6738a6 into flutter-tizen:master Aug 5, 2021
@HakkyuKim HakkyuKim deleted the update-package-info-plus branch December 21, 2021 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants