This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Build host Dart binary with -march=core2 on Mac OS X. #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the right way to disable SSE3 features and above to support
early pre-Penryn iMac-s.
-msse2 which I tried to use before does not actually disable SSE3 and above.
This time I have verified that no pextrb (SSE4.1) instructions are generated
by C++ compiler by disassembling dart binary.
Note: the binary still contains some SSE4.1 instructions because BoringSSL comes
with handwritten assembly - but it check CPU features before using that assembly.
Fixes flutter/flutter#24916
(This time for real)