Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@mraleph
Copy link
Member

@mraleph mraleph commented Apr 18, 2019

This is the right way to disable SSE3 features and above to support
early pre-Penryn iMac-s.

-msse2 which I tried to use before does not actually disable SSE3 and above.

This time I have verified that no pextrb (SSE4.1) instructions are generated
by C++ compiler by disassembling dart binary.

Note: the binary still contains some SSE4.1 instructions because BoringSSL comes
with handwritten assembly - but it check CPU features before using that assembly.

Fixes flutter/flutter#24916

(This time for real)

This is the right way to disable SSE3 features and above to support
early pre-Penryn iMac-s.

-msse2 which I tried to use before does not actually disable SSE3 and above.

This time I have verified that no pextrb (SSE4.1) instructions are generated
by C++ compiler by disassembling dart binary.

Note: the binary still contains some SSE4.1 instructions because BoringSSL comes
with handwritten assembly - but it check CPU features before using that assembly.

Fixes flutter/flutter#24916

(This time for real)
@cpalanzo
Copy link

Can someone tell me when this will be available in the SDK for installation? I see a lot of automated processes but could not find this available yet.

@mraleph
Copy link
Member Author

mraleph commented Apr 19, 2019

@cpalanzo I have not merged it yet :) I am gonna leave a comment here once it is all the way through the pipeline.

@mraleph mraleph merged commit 380d0ed into flutter:master Apr 19, 2019
@mraleph mraleph deleted the lower-sse-requirements branch April 19, 2019 12:18
@cpalanzo
Copy link

@mraleph Thank you! I appreciate the guidance - and am very impressed by the response to this issue and the quickness with which it get's resolved, reviewed, patched and pushed out - very very nice!

@cpalanzo
Copy link

@mraleph So it looks like this was committed to the Flutter Engine - but is still not in the SDK? (I'm trying to figure out the process and appreciate you taking time to educate me.)

@mraleph
Copy link
Member Author

mraleph commented Apr 23, 2019

@cpalanzo I think now it should have reached master. Could you try again?

@cpalanzo
Copy link

Yes - this works now! Thank you again for the assistance - I'm very impressed by the support within the flutter community and appreciate your direct help.

@naclcaleb
Copy link

Happy to see this fixed! It was too late to be of use to me, but great work!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flutter doctor fails due to segmentation fault (OSX 10.11.6 El Capitan)

4 participants