This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Make cppwinrt check SDK/References folder if using standard sdk location failed. #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
May 6, 2021
Member
cbracken
left a comment
cbracken
left a comment
There was a problem hiding this comment.
This lgtm, but I'm curious why the SDK path doesn't match what's expected; once we know more we should update this script with a bit more info on why it's necessary.
This was referenced May 6, 2021
christopherfujino
added a commit
to flutter/engine
that referenced
this pull request
May 7, 2021
…5954) * add flag to identify sub-trees with PlatformViewLayers and always paint them (#25824) * Roll Dart SDK to 2.13.0-211.14.beta * Roll buildroot to pick up github.com/flutter/buildroot/pull/447 * explicitly call generate_winrt_headers.py with python3 * add third_party/expat to DEPS Co-authored-by: Jim Graham <flar@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.