This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Use the framework label to import frameworks on Mac and iOS. #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required in the latest versions of GN (which I am updating to).
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Jul 13, 2021
We don't have access to Android tools of the native architecture. While it is possible to shim x64 Android tools to work on M1, I have opted to disable the Android targets instead. Currently focusing on Mac and iOS targets and don't want to spend too much time on an Android shim when we can probably just publish the right tools to the CIPD bucket and bypass emulation. The GN version has also been updated as it contains the native architecture binaries. The udpate did cause old warnings in GN rules to become errors. I have patched those here and in the buildroot. This does require a buildroot update in flutter/buildroot#480.
dnfield
approved these changes
Jul 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required in the latest versions of GN (which I am updating
to).