Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@jiahaog
Copy link
Member

@jiahaog jiahaog commented Oct 20, 2023

flutter/engine#45869 may have removed the last occurrence of this.

List which issues are fixed by this PR. You must list at least one issue.
b/300573112

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter/engine#45869 may have removed the last occurrence of this.
@jiahaog jiahaog requested a review from cbracken October 20, 2023 00:29
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; thanks! Please manually roll to engine.

@jiahaog jiahaog added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2023
@auto-submit auto-submit bot merged commit 5ced436 into flutter:master Oct 20, 2023
@jiahaog jiahaog deleted the no-c99-designator branch October 20, 2023 05:23
auto-submit bot pushed a commit to flutter/engine that referenced this pull request Oct 20, 2023
See also:

- #45869
- flutter/buildroot#788

*List which issues are fixed by this PR. You must list at least one issue.*
b/300573112
harryterkelsen pushed a commit to flutter/engine that referenced this pull request Oct 23, 2023
See also:

- #45869
- flutter/buildroot#788

*List which issues are fixed by this PR. You must list at least one issue.*
b/300573112
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants