This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Clean up goma from GN files #858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
reviewed
May 14, 2024
| # If use_goma is false, this property is ignored. | ||
| # create_xcode_symlinks = false | ||
| # If use_rbe is false, this property is ignored. | ||
| create_xcode_symlinks = false |
Member
There was a problem hiding this comment.
Did you mean to uncomment this?
Member
Author
There was a problem hiding this comment.
Yes. Uncommenting here, and deleting goma.gni under the same directory.
jason-simmons
approved these changes
May 15, 2024
zanderso
added a commit
to flutter/engine
that referenced
this pull request
May 15, 2024
This PR rolls in the buildroot to pick up flutter/buildroot#858.
eyebrowsoffire
pushed a commit
that referenced
this pull request
Jun 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in flutter/engine#52826