Skip to content

app_shared: migrate to pkg:web #6577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevmoo wants to merge 3 commits into from
Closed

app_shared: migrate to pkg:web #6577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d128795
app_shared: migrate to pkg:web
kevmoo Oct 23, 2023
84cb5ab
review nit
kevmoo Oct 23, 2023
f6f8659
revert on pkg:web change
kevmoo Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/devtools_app_shared/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
* Remove public getters `onIsolateCreated` and `onIsolateExited` from `IsolateManager`.
* Remove public getter `firstFrameReceived` from `ServiceExtensionManager`.
* Add `RoundedButtonGroup` common widget.
* Move from `dart:html` to `package:web`.

## 0.0.6
* Add `profilePlatformChannels` to known service extensions.
Expand Down
4 changes: 1 addition & 3 deletions packages/devtools_app_shared/lib/src/ui/theme/_ide_theme_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be found
// in the LICENSE file.

// ignore: avoid_web_libraries_in_flutter, as designed
import 'dart:html';

import 'package:flutter/widgets.dart';
import 'package:logging/logging.dart';
import 'package:web/helpers.dart';

import '../../utils/url/url.dart';
import '../../utils/utils.dart';
Expand Down
1 change: 1 addition & 0 deletions packages/devtools_app_shared/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ dependencies:
meta: ^1.9.1
pointer_interceptor: ^0.9.3+3
vm_service: ^12.0.0
web: ^0.3.0

dev_dependencies:
flutter_lints: ^2.0.3
Expand Down