-
Notifications
You must be signed in to change notification settings - Fork 364
Compile release build of DevTools with default dart2js optimizations #7335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kenzieschmoll
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to update build_release.sh too. The automated builder that uploads DevTools builds to CIPD uses that script
|
I think this pr broke |
Uh oh, thanks! Will take a look |
|
I'm curious, is the use O1 is meant to be temporary while debugging the other issue or a permanent change? Just in case this is not temporary, let me suggest a couple other strategies that could provide a better balance of performance and debugability.
The latter requires a bit more setup, but it's the recommended approach to ship minified apps and still be able to get meaningful stack traces from production runs. |
|
Re option (2), I was trying to see if I could lookup the stack provided in #7305, but I noticed that devtools currently doesn't ship it's sourcemap file. Is that correct? Is it by chance built and saved somewhere that could be accessed retroactively? If not, that would be the main thing we need to do to make it possible to use the deobfuscation tools. We could try to rebuild the exact same state, but it would require using the exact same version of flutter/dart as it was used at the time the release was made (in this example, for devtools 2.31.1), which is likely hard to do. |
Work towards #7192
It would be helpful for DevTools bug reports to have more intelligible stack traces. This PR changes DevTools to use unminified dart2js. See https://dart.dev/tools/dart-compile#js for information about the varous optimization levels.