Skip to content

Don't compile DevTools with unminified JS #7382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elliette wants to merge 1 commit into from
Closed

Don't compile DevTools with unminified JS #7382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tool/build_release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ flutter pub get
flutter build web \
--web-renderer canvaskit \
--pwa-strategy=offline-first \
--dart2js-optimization=O1 \
# TODO(elliette): Compile with O1 optimization once
# https://github.com/dart-lang/sdk/issues/55234 is fixed:
# --dart2js-optimization=O1 \
--release \
--no-tree-shake-icons

Expand Down
4 changes: 3 additions & 1 deletion tool/lib/commands/build.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,10 @@ class BuildCommand extends Command {
'--web-renderer',
'canvaskit',
'--pwa-strategy=offline-first',
// TODO(elliette): Compile with O1 optimization once
// https://github.com/dart-lang/sdk/issues/55234 is fixed:
// Enable default optimizations: https://dart.dev/tools/dart-compile#js
'--dart2js-optimization=O1',
// '--dart2js-optimization=O1',
if (buildMode != 'debug') '--$buildMode',
'--no-tree-shake-icons',
],
Expand Down